Skip to content

BUG: Fix drop_duplicates failure when DataFrame has no column #20974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

BUG: Fix drop_duplicates failure when DataFrame has no column #20974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f4f58e
BUG: Fix drop_duplicates failure when DataFrame has no column
Licht-T May 7, 2018
95a07a2
TST: Add test for drop_duplicates with no column DataFrame
Licht-T May 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pandas/core/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4354,6 +4354,9 @@ def duplicated(self, subset=None, keep='first'):
from pandas.core.sorting import get_group_index
from pandas._libs.hashtable import duplicated_int64, _SIZE_HINT_LIMIT

if self.columns.empty:
return Series()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dtype='bool'?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to be explicit here. We'll be changing this from float to object soon.


def f(vals):
labels, shape = algorithms.factorize(
vals, size_hint=min(len(self), _SIZE_HINT_LIMIT))
Expand Down
10 changes: 10 additions & 0 deletions pandas/tests/frame/test_analytics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1522,6 +1522,16 @@ def test_drop_duplicates_with_duplicate_column_names(self):
expected1 = df[:2]
tm.assert_frame_equal(result1, expected1)

def test_drop_duplicates_with_no_column(self):
# GH20516
df0 = DataFrame()
result0 = df0.drop_duplicates()
tm.assert_frame_equal(result0, df0)

df1 = DataFrame(index=[1, 2])
result1 = df1.drop_duplicates()
tm.assert_frame_equal(result1, df1)

def test_drop_duplicates_for_take_all(self):
df = DataFrame({'AAA': ['foo', 'bar', 'baz', 'bar',
'foo', 'bar', 'qux', 'foo'],
Expand Down