BUG: Fixed Series.align(frame) with ExtensionArray #20580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAugspurger
added
Missing-data
|
That fixed it! Thanks |
Codecov Report
@@ Coverage Diff @@
## master #20580 +/- ##
==========================================
+ Coverage 91.82% 91.82% +<.01%
==========================================
Files 152 152
Lines 49255 49255
==========================================
+ Hits 45226 45228 +2
+ Misses 4029 4027 -2
Continue to review full report at Codecov.
|
| @@ -64,6 +65,20 @@ def test_align_frame(self, data, na_value): | |||
| self.assert_frame_equal(r1, e1) | |||
| self.assert_frame_equal(r2, e2) | |||
|
|
|||
| def test_align_series_frame(self, data, na_value): | |||
| # /Users/taugspurger/sandbox/pandas-ip/pandas/pandas/tests/extension/base/reshaping.py | |||
There was a problem hiding this comment.
suppose this is a left over?
| @@ -75,6 +75,10 @@ def test_align(self, data, na_value): | |||
| def test_align_frame(self, data, na_value): | |||
| pass | |||
|
|
|||
| @pytest.mark.skip(reason="Unobserved categories preseved in concat.") | |||
| def test_align_series_frame(self, data, na_value): | |||
There was a problem hiding this comment.
Isn't this only because the way the test is constructed? You can also do it with the full of data instead of only the first 3 elements. Then this is not an issue?
jorisvandenbossche
approved these changes
Apr 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20576
cc @jorisvandenbossche