Skip to content

DOC: Formatting for DtypeWarning Docstring [ci skip] #20329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2018

Conversation

TomAugspurger
Copy link
Contributor

@TomAugspurger TomAugspurger added Docs IO Data IO issues that don't fit into a more specific label IO CSV read_csv, to_csv labels Mar 13, 2018
@TomAugspurger TomAugspurger added this to the 0.23.0 milestone Mar 13, 2018
@TomAugspurger
Copy link
Contributor Author

Stiill have the issue with the warning going to stdout. Here's the tail of the validation script.

No warning was issued.

>>> import os
>>> os.remove('test.csv')
scripts/validate_docstrings.py:268: DtypeWarning: Columns (0) have mixed types. Specify dtype option on import or set low_memory=False.
  runner.run(test)

################################################################################
################################## Validation ##################################
################################################################################

Errors found:
        No returns section found

@jorisvandenbossche
Copy link
Member

For the validation script I think it is not that much of a problem. But for pytest, I think we don't want to generally capture and silence the warnings, as there might be others raised in docstrings that we want to get notified of.

@TomAugspurger TomAugspurger merged commit c805368 into pandas-dev:master Mar 13, 2018
@TomAugspurger TomAugspurger deleted the dtype-warning branch March 13, 2018 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs IO CSV read_csv, to_csv IO Data IO issues that don't fit into a more specific label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants