-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
DOC: update the DatetimeIndex.tz_convert(tz) docstring #20096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
b062d66
82c6546
d16d9ef
2179e2d
74ba82a
4f7a570
7a003de
fac2544
236e00b
1b56342
f8e4024
c136136
3d9b5b5
1f0adfc
ff00665
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1904,24 +1904,48 @@ def delete(self, loc): | |
|
||
def tz_convert(self, tz): | ||
""" | ||
Convert tz-aware DatetimeIndex from one time zone to another (using | ||
pytz/dateutil) | ||
Convert tz-aware DatetimeIndex from one | ||
time zone to another. | ||
|
||
When using DatetimeIndex providing with timezone this method | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a cumbersome sentence and is pretty duplicative of the above, I would remove it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I regret the auto typing mistake, I wanted to convey that i will surely be doing it as per recommended by you. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @hammadmashkoor no problem. thanks for the PR! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think this extended summary is needed at all as its duplicated of the Summary. |
||
converts tz-aware DatetimeIndex using pytz/dateutil. | ||
|
||
Parameters | ||
---------- | ||
tz : string, pytz.timezone, dateutil.tz.tzfile or None | ||
Time zone for time. Corresponding timestamps would be converted to | ||
time zone of the TimeSeries. | ||
Time zone for time.Corresponding timestamps would be converted | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You seemed to have removed a space between the two words, which I suppose was a mistake. |
||
to time zone of the TimeSeries. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. TimeSeries -> DatetimeIndex |
||
None will remove timezone holding UTC time. | ||
|
||
Returns | ||
------- | ||
normalized : DatetimeIndex | ||
|
||
Raises | ||
------ | ||
------- | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change is not needed (the line under the title can be exactly as long as the title itself) |
||
TypeError | ||
If DatetimeIndex is tz-naive. | ||
|
||
See Also | ||
-------- | ||
tz_localize : Localize tz-naive DatetimeIndex to given time zone | ||
(using pytz/dateutil),or remove timezone from tz-aware | ||
DatetimeIndex. | ||
|
||
Examples | ||
-------- | ||
>>> datetime=pd.Series(pd.date_range('20180301',periods=3)) | ||
>>> datetime | ||
0 2018-03-01 | ||
1 2018-03-02 | ||
2 2018-03-03 | ||
dtype: datetime64[ns] | ||
|
||
>>> datetime.dt.tz_localize('UTC').dt.tz_convert('US/Eastern') | ||
0 2018-02-28 19:00:00-05:00 | ||
1 2018-03-01 19:00:00-05:00 | ||
2 2018-03-02 19:00:00-05:00 | ||
dtype: datetime64[ns, US/Eastern] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you also add an example that uses |
||
""" | ||
tz = timezones.maybe_get_tz(tz) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you put this on one line? (I think it should fit within 80 chars)