Skip to content

DOC: Link to Python 3 versions of official Python docs #18962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2017

Conversation

jschendel
Copy link
Member

  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

Went through and made sure that all links to the official Python docs start with https://docs.python.org/3/ to ensure that the links go to the most recent stable version of Python 3.

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be worthwhile to add a lint rule that rejects python links that are not 3?

@codecov
Copy link

codecov bot commented Dec 28, 2017

Codecov Report

Merging #18962 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18962   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files         150      150           
  Lines       48924    48924           
=======================================
  Hits        44813    44813           
  Misses       4111     4111
Flag Coverage Δ
#multiple 89.95% <ø> (ø) ⬆️
#single 41.16% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/computation/eval.py 97.11% <ø> (ø) ⬆️
pandas/core/indexes/datetimelike.py 97.19% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e567949...8c18942. Read the comment docs.

@jreback jreback added the Docs label Dec 28, 2017
@jreback jreback added this to the 0.23.0 milestone Dec 28, 2017
@jreback jreback merged commit e1b638e into pandas-dev:master Dec 28, 2017
@jreback
Copy link
Contributor

jreback commented Dec 28, 2017

thanks!

@jschendel jschendel deleted the doc-py3-links branch December 28, 2017 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants