Skip to content

CLN: ASV panel ctor #18915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2017
Merged

Conversation

mroeschke
Copy link
Member

There were two benchmarks that were essentially the same (dictionary of dataframes with the same index benchmark), so I removed one along with the usual flake8.

$ asv dev -b ^panel_ctor
· Discovering benchmarks
· Running 3 total benchmarks (1 commits * 1 environments * 3 benchmarks)
[  0.00%] ·· Building for existing-py_home_matt_anaconda_envs_pandas_dev_bin_python
[  0.00%] ·· Benchmarking existing-py_home_matt_anaconda_envs_pandas_dev_bin_python
[ 33.33%] ··· Running panel_ctor.DifferentIndexes.time_from_dict          387ms
[ 66.67%] ··· Running panel_ctor.SameIndexes.time_from_dict              32.0ms
[100.00%] ··· Running panel_ctor.TwoIndexes.time_from_dict                105ms

@codecov
Copy link

codecov bot commented Dec 23, 2017

Codecov Report

Merging #18915 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18915      +/-   ##
==========================================
+ Coverage   91.65%   91.67%   +0.02%     
==========================================
  Files         154      154              
  Lines       51368    51368              
==========================================
+ Hits        47080    47092      +12     
+ Misses       4288     4276      -12
Flag Coverage Δ
#multiple 89.54% <ø> (+0.02%) ⬆️
#single 40.84% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/plotting/_converter.py 66.95% <0%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6164da2...124aded. Read the comment docs.

@jreback jreback added the Benchmark Performance (ASV) benchmarks label Dec 23, 2017
@jreback jreback added this to the 0.23.0 milestone Dec 23, 2017
@jreback jreback merged commit 86f78af into pandas-dev:master Dec 23, 2017
@jreback
Copy link
Contributor

jreback commented Dec 23, 2017

thanks!

@mroeschke mroeschke deleted the asv_clean_panel_ctor branch December 24, 2017 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmark Performance (ASV) benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants