-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
REF: repr - allow block to override values that get formatted #17143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jorisvandenbossche
merged 6 commits into
pandas-dev:master
from
jorisvandenbossche:internals-formatted-values
Aug 4, 2017
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f6e376f
REF: repr - allow block to override values that get formatted
jorisvandenbossche ec7ff5d
extra redirect + move tests
jorisvandenbossche 7e259c9
add to setup.py + specify int64 in test
jorisvandenbossche 000c6fc
Merge remote-tracking branch 'upstream/master' into internals-formatt…
jorisvandenbossche dcd3c0f
remove usage of fastpath in test example
jorisvandenbossche b41b713
pep8
jorisvandenbossche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
# -*- coding: utf-8 -*- | ||
# pylint: disable=W0102 | ||
|
||
import numpy as np | ||
|
||
import pandas as pd | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. maybe make a sub-dir for internals tests |
||
from pandas.core.internals import Block, BlockManager | ||
|
||
|
||
class CustomBlock(Block): | ||
|
||
def formatting_values(self): | ||
return np.array(["Val: {}".format(i) for i in self.values]) | ||
|
||
|
||
def test_custom_repr(): | ||
values = np.arange(3) | ||
|
||
# series | ||
block = CustomBlock(values, placement=slice(0, 3)) | ||
s = pd.Series(block, index=pd.RangeIndex(3), fastpath=True) | ||
assert repr(s) == '0 Val: 0\n1 Val: 1\n2 Val: 2\ndtype: int64' | ||
|
||
# dataframe | ||
block = CustomBlock(values.reshape(1, -1), placement=slice(0, 1)) | ||
blk_mgr = BlockManager([block], [['col'], range(3)]) | ||
df = pd.DataFrame(blk_mgr) | ||
assert repr(df) == ' col\n0 Val: 0\n1 Val: 1\n2 Val: 2' |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jreback I could also add one extra level of redirection. Instead of now Series -> Block, I could also do Series -> SingleBlockManager -> Block. For that I just need to add a
formatting_values
to SingleBlockManager that calls Block.formatting_values(). But is seems an extra unneeded layer, although forinternal_values
orget_values
it is done like this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes I would add the indirection level