Skip to content

BUG: pass *args and **kwargs for wrapped methods in Groupby (#14107) #14109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

yonatanp
Copy link

Methods such as 'hist' that take keyword arguments would now be able to be called via a Groupby object and the keyword args would be passed onwards to matplotlib as the user expects.

…ndas-dev#14107)

Methods such as 'hist' that take keyword arguments would now be able to be called via a Groupby object and the keyword args would be passed onwards to matplotlib as the user expects.
@jreback
Copy link
Contributor

jreback commented Aug 28, 2016

tests!

@jreback jreback added the Visualization plotting label Aug 28, 2016
@codecov-io
Copy link

codecov-io commented Aug 28, 2016

Current coverage is 85.24% (diff: 0.00%)

Merging #14109 into master will decrease coverage by 0.02%

@@             master     #14109   diff @@
==========================================
  Files           139        140     +1   
  Lines         50502      50556    +54   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43063      43094    +31   
- Misses         7439       7462    +23   
  Partials          0          0          

Powered by Codecov. Last update a0151a7...429509e

@jreback
Copy link
Contributor

jreback commented Sep 8, 2016

pls add tests

@yonatanp
Copy link
Author

yonatanp commented Sep 9, 2016

BTW, I just removed a duplicate dictionary entry on test_tslib.py.
It was there for a year now and I have no idea how anything was able to pass lint until now.

@yonatanp
Copy link
Author

yonatanp commented Sep 9, 2016

I'll need some help at this point (@jreback or others available). My change was a simple one-liner, and I added a test that fails without my change and succeeds with it; so I'm pretty certain my change is fully covered.
However codecov/patch says 0.00%. I'm not sure what it means and how to fix it. Help?

@yonatanp
Copy link
Author

Pinging again. I'd really love to contribute this tiny piece, but if it is just remaining as clutter, I'll remove the PR to avoid future confusion.

@jreback
Copy link
Contributor

jreback commented Nov 22, 2016

I think your example fails in current master. can you clarify?

@jreback
Copy link
Contributor

jreback commented Dec 26, 2016

@yonatanp I am still unclear what the exact issue is here, can you show an example?

@jreback
Copy link
Contributor

jreback commented Jan 21, 2017

can you rebase

@jreback
Copy link
Contributor

jreback commented Mar 20, 2017

can you rebase / update

@jreback
Copy link
Contributor

jreback commented Apr 3, 2017

closing as stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pandas.core.groupby.SeriesGroupBy.hist doesn't propagate **kwargs
3 participants