-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
BUG: pass *args and **kwargs for wrapped methods in Groupby (#14107) #14109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ndas-dev#14107) Methods such as 'hist' that take keyword arguments would now be able to be called via a Groupby object and the keyword args would be passed onwards to matplotlib as the user expects.
tests! |
Current coverage is 85.24% (diff: 0.00%)@@ master #14109 diff @@
==========================================
Files 139 140 +1
Lines 50502 50556 +54
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43063 43094 +31
- Misses 7439 7462 +23
Partials 0 0
|
pls add tests |
BTW, I just removed a duplicate dictionary entry on |
I'll need some help at this point (@jreback or others available). My change was a simple one-liner, and I added a test that fails without my change and succeeds with it; so I'm pretty certain my change is fully covered. |
Pinging again. I'd really love to contribute this tiny piece, but if it is just remaining as clutter, I'll remove the PR to avoid future confusion. |
I think your example fails in current master. can you clarify? |
@yonatanp I am still unclear what the exact issue is here, can you show an example? |
can you rebase |
can you rebase / update |
closing as stale |
git diff upstream/master | flake8 --diff
Methods such as 'hist' that take keyword arguments would now be able to be called via a Groupby object and the keyword args would be passed onwards to matplotlib as the user expects.