ENH: Enable automatic writing of dates to Stata files #13710
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self._convert_dates[key] | ||
| ) | ||
| dtypes[key] = np.dtype(new_type) | ||
| dtypes[key] = np.dtype(new_type) |
There was a problem hiding this comment.
this would blow up if they did convert_dates on a datetime64-tz aware type
There was a problem hiding this comment.
is_datetime64_dtype is False for tz aware datetimes.
jreback
added
Dtype Conversions
bashtage
force-pushed
the
correct-stata-date-handling
branch
from
0b3a253 to
7b5f321
Compare
Current coverage is 84.53%
|
bashtage
force-pushed
the
correct-stata-date-handling
branch
2 times, most recently
from
991ec0e to
73f6565
Compare
| @@ -432,7 +432,8 @@ def parse_dates_safe(dates, delta=False, year=False, days=False): | |||
| d = parse_dates_safe(dates, year=True) | |||
| conv_dates = d.year | |||
| else: | |||
| raise ValueError("fmt %s not understood" % fmt) | |||
There was a problem hiding this comment.
is this where you validate the supported format? (e.g. the tc and such). I think this would be a ValueError if its not in the list (yes unsupported sort of means this, but more likely it was a typo by the user). and datetime w/tz can be not implemented error.
There was a problem hiding this comment.
Revered this to ValueError since it should only raise if the type doesn't exist.
Automatically select type %tc for datetime[ns] columns Change ValueErrors to NotImplementedError for unsupported types Add tests for select exceptions Improve to_stata and StataWriter docstrings closes pandas-dev#12259
bashtage
force-pushed
the
correct-stata-date-handling
branch
from
73f6565 to
f77e40a
Compare
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffAutomatically select type %tc for datetime[ns] columns
Change ValueErrors to NotImplementedError for unsupported types
Add tests for select exceptions
closes #12259