-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
BUG: is_normalized returned False for local tz #13484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Current coverage is 84.33%@@ master #13484 diff @@
==========================================
Files 138 138
Lines 51083 51106 +23
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43083 43102 +19
- Misses 8000 8004 +4
Partials 0 0
|
raise nose.SkipTest("timezone setting not supported on windows") | ||
|
||
import os | ||
import time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do this in a loop for several timezones (e.g. Asia/Kolka, US/Eastern, UTC)
@@ -524,3 +524,5 @@ Bug Fixes | |||
|
|||
|
|||
- Bug in ``Categorical.remove_unused_categories()`` changes ``.codes`` dtype to platform int (:issue:`13261`) | |||
|
|||
- Bug in ``tslib.dates_normalized`` returns False in case of normalized date_range for local timezone ``Asia/Kolkata`` (:issue:`13459`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From user's point of view, it should describe the change related to DatetimeIndex.is_normalized
. Also, it affects to all tz (not only to Kolkata).
@jreback Please review. |
|
||
@contextmanager | ||
def set_timezone(tz): | ||
import os |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a doc-string with Parameters here (it must also be a string, so you should str(tz) somewhere.
looks good. just a few doc comments. ping when green. |
so appears If you can then we need to do a platform check inside the context manager and raise a Skiptest (though maybe just have the context manager raise something helpful and let the test writer worry about the skip) |
is_normalized returned False for normalized date_range in case of local timezone 'Asia/Kolkata' Fixes: #13459
@jreback Its green. How does it look now? |
thanks! |
git diff upstream/master | flake8 --diff
is_normalized returned False for normalized date_range
in case of local timezone 'Asia/Kolkata'
Fixes: #13459