-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
PEP: pandas/core round 3 (generic, groupby, index) #12062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
No github diffs again! There are some pieces of code that I think can be removed but want to confirm: |
|
yeh that looks not tested, it for a transform on a Panel or greater. I think just raise |
I assume it should be |
k, I can do that. |
@rockg I would keep style changes and code clean-up (as in removal of unused code or a change of actual code) strictly separated (at least in a separate commit). Just to be sure, in case we overlooked something, then it is not burried in a gigantic commit for which you can't see the diff. |
The main goal of this exercise is to make flake8 pass and cleanup some style were necessary. What I cleaned out were unused variables reported by flake8 and, as a result, I don't see a problem including that here. |
@rockg I've been putting |
This is especially important in unit tests where I suspect that there are some test cases that may have skipped some intended checks |
Okay, that seems reasonable. |
ok, rebasing |
Is this good to merge? |
I'll leave this to @jreback with the pending rebase |
if u want to remove groupby.py from this would be great (I'll catch that in resample fixes) otherwise lgtm |
thanks! we're almost there =) |
yapf with manual modifications for error strings and bad yapf formatting.