BUG: read_excel fails when empty sheets exist and sheetname=None #11711 #11819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Bug
IO Excel
| @@ -197,3 +197,5 @@ Bug Fixes | |||
| - Bug in ``pd.rolling_median`` where memory allocation failed even with sufficient memory (:issue:`11696`) | |||
|
|
|||
| - Bug in ``df.replace`` while replacing value in mixed dtype ``Dataframe`` (:issue:`11698`) | |||
|
|
|||
| - Bug in ``read_excel`` failing to read any non-empty sheets when empty sheets exist and sheetname=None (:issue:`11711`) | |||
There was a problem hiding this comment.
use double backticks around sheetname=None
sxwang
force-pushed
the
read_excel_empty
branch
from
6e73329 to
9df5fb8
Compare
|
does this cover both cases in #11711 (IIRC blank sheet in middle was ok, at end was buggy) but was there another case? |
|
ok lgtm. ping when green. |
|
build done & green |
jreback
added a commit
that referenced
this pull request
Dec 12, 2015
BUG: read_excel fails when empty sheets exist and sheetname=None #11711
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #11711.
Existing code prematurely returns an empty dataframe when an empty sheet in the source excel file is encountered.
Fix is to store an empty dataframe in the output dict and continue to the next sheet.