Skip to content

BUG: Fixed bug that Timedelta raises error when slicing from 0s (issue #10583) #10957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

terrytangyuan
Copy link
Contributor

closes #10583

@jreback
Copy link
Contributor

jreback commented Sep 1, 2015

lgtm. pls add a whatsnew note. ping when green.

@jreback jreback added Bug Timedelta Timedelta data type labels Sep 1, 2015
@jreback jreback added this to the 0.17.0 milestone Sep 1, 2015
@terrytangyuan
Copy link
Contributor Author

I just messed up my last push. It combined some of your previous commits...would this still be ok? I am not sure how to make it back...

@jreback
Copy link
Contributor

jreback commented Sep 1, 2015

see how to here: http://pandas.pydata.org/pandas-docs/stable/contributing.html

you need to rebase on master

@terrytangyuan
Copy link
Contributor Author

I've created a new PR here. Sorry for any inconvenience.

@TomAugspurger
Copy link
Contributor

FYI you probably would have been able to recover with git reflog, which records all the states your branch has been in. You'd use that to find which hash to git reset back to.

@terrytangyuan
Copy link
Contributor Author

Got it. Thanks!
On Sep 1, 2015 8:55 AM, "Tom Augspurger" notifications@github.com wrote:

FYI you probably would have been able to recover with git reflog, which
records all the states your branch has been in. You'd use that to find
which hash to git reset back to.


Reply to this email directly or view it on GitHub
#10957 (comment).

@terrytangyuan terrytangyuan deleted the PR2new branch September 1, 2015 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Timedelta Timedelta data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TimedeltaIndex raises error when slicing from '0s'
3 participants