Skip to content

CI: create/drop pandas_nosetest db on class instatiation #7091

Closed
@jreback

Description

@jreback

So I think that the SQL test classes should inherit from:

https://github.com/pydata/pandas/blob/master/pandas/util/testing.py#L65

then you can add

class BaseSQLTestCase(tm.TestCase):

   @classmethod
    def setUpClass(cls):
        super(BaseSQLTestCase, cls).setUpClass()

        # create the ``pandas_nosetest`` db here

   @classmethod
    def tearDownClass(cls):
        super(BaseSQLTestCase, cls).tearDownClass()

        # drop the ``pandas_nosetest`` db here

and remove this:
https://github.com/pydata/pandas/blob/master/.travis.yml#L100

This doesn't affect travis, but testing on a static platform (e.g. windows)
where the database in theory could have something in it (if a test was stopped in the middle) and then the next time it runs their is stuff there

Metadata

Metadata

Assignees

No one assigned

    Labels

    CIContinuous IntegrationIO SQLto_sql, read_sql, read_sql_query

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions