Improve config lookups when you know exactly what key you want

[jtratner]

Right now sometimes getting config options iterates over a list filtering on regular expressions, which seems like overdoing it when internal code knows exactly what it wants. Makes sense to add getitem and set item to bypass the checks (and then add an update method to set up everything).

7aa7880f#diff-1e746a348e7db9596f3d053134d00e74R515

[cpcloud]

😄 i think i added those regex lookups

[cpcloud]

back in the days of yore

[jtratner]

I noticed it when I found this repr method calling re.search about 40 times just to get encoding, seemed like overkill. Also, should change it to compile the regex once rather than passing to re.search each time...

[cpcloud]

sure def compile ... why was it being called so many times

[jtratner]

There's some list comprehension that filters on re search. (I think it's
in config, maybe I'm mistaken)
On Oct 7, 2013 10:37 PM, "Phillip Cloud" notifications@github.com wrote:

sure def compile ... why was it being called so many times

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/5147#issuecomment-25861092
.

[cpcloud]

actually no wasn't me ... in any event i see what ur talking about

[jreback]

@cpcloud push?

[jtratner]

Go ahead, it's trivial, but no reason to be a blocker.

[jreback]

you can of course do it for 0.13! just trying to clear the boards

#5565 improves this 10x to 5us per lookup, using jeff's would give an additional 5x to <1us.
It's probably good enough, but leaving open for now.

@jtratner , is there a place you've seen where those extra us matter?

[jreback]

I think this can be closed, yes? (though maybe someone should go thru code and make sure that lookups of options are standardized)

It's always been get_option because until recently that was the only way
to get the option value. I went through when config was introduced and
converted everything over. I think we're good. closing.