python3 test_value_counts_nunique : TypeError: unhashable type: 'NaTType'

[yarikoptic]

on sparc 4c2d050

======================================================================
ERROR: test_value_counts_nunique (pandas.tests.test_series.TestSeries)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/yoh/deb/gits/pkg-exppsy/pandas/debian/tmp/usr/lib/python3/dist-packages/pandas/tests/test_series.py", line 2633, in test_value_counts_nunique
    result = s.value_counts()
  File "/home/yoh/deb/gits/pkg-exppsy/pandas/debian/tmp/usr/lib/python3/dist-packages/pandas/core/series.py", line 1422, in value_counts
    normalize=normalize)
  File "/home/yoh/deb/gits/pkg-exppsy/pandas/debian/tmp/usr/lib/python3/dist-packages/pandas/core/algorithms.py", line 186, in value_counts
    keys, counts = htable.value_count_object(values, mask)
  File "hashtable.pyx", line 935, in pandas.hashtable.value_count_object (pandas/hashtable.c:14937)
TypeError: unhashable type: 'NaTType'

[cpcloud]

that's a weird error....NaTType hashes an int or it hashes its datetime value.

what happens when you try just

import pandas as pd
hash(pd.NaT)

?

[jreback]

@cpcloud

i suppose in theory the NaT could fail internally if for some reason the nanosecond field were assigned to 0
then this would fallback on the datetime.hash which should still work (though might be undefined)...in any event this trivial change SHOULD fix it

@yarikoptic can you try off of the above PR #4269 to see if this fixes? I can't easily test this...

[jreback]

@yarikoptic I merged this in...hopefully will fix, if not ping us back

thanks!

[jreback]

will leave open till @yarikoptic verifies

[jreback]

@yarikoptic resolved?

[yarikoptic]

seems to be resolved

$> grep -e nosetests -e 'test_value_counts_nunique.*pandas.tests.test_series.TestSeries' ../vagus-withbs4-3.log
    cd build/; python2.7 /usr/bin/nosetests -s -v -a '!network'  pandas;
test_value_counts_nunique (pandas.tests.test_series.TestSeries) ... ok
    cd build/; python3.2 /usr/bin/nosetests -s -v -a '!network'  pandas;
test_value_counts_nunique (pandas.tests.test_series.TestSeries) ... ok