Skip to content

CI: ASV Bot #41157

Closed
Closed
@lithomas1

Description

@lithomas1

Is your feature request related to a problem?

Running ASV's takes a really long time, especially with old computers, and the ASVs in PRs are not run in continuous mode, which makes it hard to find regressions before a PR is merged.

asv dev | sed "/failed$/ s/^/##[error]/" | tee benchmarks.log

(master, what we run currently, asv dev)

Describe the solution you'd like

A github actions workflow that runs asv continuous -f 1.1 upstream/master HEAD on PRs after seeing a comment such as @github-actions asv. In order to prevent false positives, I think the bot should first merge in master to a PR before running benchmarks.

autotune:
name: "Fixup pre-commit formatting"
if: startsWith(github.event.comment.body, '@github-actions pre-commit')

(example for triggering)

Afterwards, the bot should comment the results. (I'm not sure how to do this)

I don't think it should be a check, since it takes a while to run and might be flaky. Making it a check would run it on every commit in a PR which would make CI queue times longer for everyone.

Additional context

#36860 https://pandas.pydata.org/docs/development/roadmap.html#performance-monitoring

Metadata

Metadata

Assignees

Labels

BenchmarkPerformance (ASV) benchmarksCIContinuous IntegrationEnhancement

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions