BUG: read_excel not accepting encoding on 1.1.0

[staticdev]

• I have checked that this issue has not already been reported.

• I have confirmed this bug exists on the latest version of pandas.

• (optional) I have confirmed this bug exists on the master branch of pandas.

---

Note: Please read this guide detailing how to provide the necessary information for us to reproduce your bug.

Code Sample, a copy-pastable example

# Your code here
def date_parse(value: str) -> datetime.datetime:
    return datetime.datetime.strptime(value.strip(), "%d/%m/%y")

df = pd.read_excel(
    filepath,
    encoding="iso-8859-1",
    usecols="B",
    date_parser=date_parse,
    skiprows=4,
)

Problem description

TypeError: read_excel() got an unexpected keyword argument 'encoding'.

Expected Output

No error, as in previous versions.

Output of pd.show_versions()

------------------
commit           : d9fff2792bf16178d4e450fe7384244e50635733
python           : 3.8.2.final.0
python-bits      : 64
OS               : Linux
OS-release       : 5.4.0-42-generic
Version          : #46-Ubuntu SMP Fri Jul 10 00:24:02 UTC 2020
machine          : x86_64
processor        : x86_64
byteorder        : little
LC_ALL           : None
LANG             : en_US.UTF-8
LOCALE           : pt_BR.UTF-8

pandas           : 1.1.0
numpy            : 1.18.5
pytz             : 2020.1
dateutil         : 2.8.1
pip              : 20.1
setuptools       : 41.2.0
Cython           : None
pytest           : 6.0.1
hypothesis       : None
sphinx           : 3.2.0
blosc            : None
feather          : None
xlsxwriter       : None
lxml.etree       : None
html5lib         : None
pymysql          : None
psycopg2         : None
jinja2           : 2.11.2
IPython          : None
pandas_datareader: None
bs4              : None
bottleneck       : None
fsspec           : None
fastparquet      : None
gcsfs            : None
matplotlib       : None
numexpr          : None
odfpy            : None
openpyxl         : None
pandas_gbq       : None
pyarrow          : None
pytables         : None
pyxlsb           : None
s3fs             : None
scipy            : None
sqlalchemy       : None
tables           : None
tabulate         : None
xarray           : None
xlrd             : 1.2.0
xlwt             : None
numba            : None```

</details>

[simonjayhawkins]

Thanks @staticdev for the report. This is documented in the release notes.

from https://pandas.pydata.org/docs/whatsnew/v1.1.0.html

read_excel() no longer takes **kwds arguments. This means that passing in the keyword argument chunksize now raises a TypeError (previously raised a NotImplementedError), while passing in the keyword argument encoding now raises a TypeError (GH34464)

were the constructed DataFrames different with and without the encoding parameter in 1.0.5?

updated: incorrect link

xref #34464

[twoertwein]

There have been similar requests about an encoding parameter: #25523 and #23444.

I haven't used read_excel but the documentation says that you can also provide a file-object instead of a path. Something like

with open(path_to_excel_file, mode="r", encoding="iso-8859-1") as file:
    df = pd.read_excel(file, **other_kwargs)

might be a temporary work around? I haven't tested whether that works.

[staticdev]

Thanks @staticdev for the report. This is documented in the release notes.

from https://pandas.pydata.org/docs/whatsnew/v1.1.0.html

read_excel() no longer takes **kwds arguments. This means that passing in the keyword argument chunksize now raises a TypeError (previously raised a NotImplementedError), while passing in the keyword argument encoding now raises a TypeError (GH34464)

were the constructed DataFrames different with and without the encoding parameter in 1.0.5?

Yes, and I was using 1.0.5 before 1.1.0 working fine.

updated: incorrect link

xref #34464

Another odd thing to add about this change is that I have another point in my code that hasn't broken and I also using kwargs and also encoding:

df = pd.read_excel(
    filename,
    encoding="iso-8859-1",
    usecols="B:K",
    parse_dates=["Date"],
    date_parser=date_parse,
    skipfooter=4,
    skiprows=10,
)

[staticdev]

There have been similar requests about an encoding parameter: #25523 and #23444.

I haven't used read_excel but the documentation says that you can also provide a file-object instead of a path. Something like

with open(path_to_excel_file, mode="r", encoding="iso-8859-1") as file:
    df = pd.read_excel(file, **other_kwargs)

might be a temporary work around? I haven't tested whether that works.

I also tried that, but created many side-effects to my code. I have a test with a file-fake that checks if it is an empty file, it should raise pd.errors.EmptyDataError, now it is giving me TypeError('expected str, bytes or os.PathLike object, not NoneType').

[twoertwein]

There have been similar requests about an encoding parameter: #25523 and #23444.
I haven't used read_excel but the documentation says that you can also provide a file-object instead of a path. Something like

with open(path_to_excel_file, mode="r", encoding="iso-8859-1") as file:
    df = pd.read_excel(file, **other_kwargs)

might be a temporary work around? I haven't tested whether that works.

I also tried that, but created many side-effects to my code. I have a test with a file-fake that checks if it is an empty file, it should raise pd.errors.EmptyDataError, now it is giving me TypeError('expected str, bytes or os.PathLike object, not NoneType').

I just noticed that my suggestion doesn't make much sense. The excel file needs to be opened in binary mode but binary files don't take an encoding argument.

[twoertwein]

Does someone know how to create an excel file with a specific encoding using either LibreOffice or gnumeric? There are no excel files needing a non-default encoding in pandas/tests/io/data/excel/. Need to have a test for the encoding argument.