Skip to content

CLN: Returned dtype of _get_cython_function unused #19557

Closed
@WillAyd

Description

@WillAyd

Minor code cleanup opportunity here. _get_cython_function in core/groupby returns a tuple containing a function and a dtype_str. While the latter is unpacked, it never appears to be used in code that calls it.

return func, dtype_str

As an alternate to removing it, it may serve some purpose if the below line is refactored to use it rather than creating its own local variable, but unless there's some other purposes I'd still just suggest cleaning up the _get_cython_function itself

out_dtype = '%s%d' % (values.dtype.kind, values.dtype.itemsize)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions