Skip to content

CLN: remove need for *VectorData c-structures in hashtable.pyx #14879

Closed
@jreback

Description

@jreback

post #14859

See what I did for StringHashTable here

I think we should just remove entirely the *VectorData structures and simply create them in a single pass at the end.

I don't think this will actually have a perf penalty, but should see if anything changes.

This will make the code easier to understand and still provide all of the GIL release benefits (because we actually need to hold the GIL to resize), if we use the method above, then can simply allocate the unique array all at once, then fill it with a single expression that doesn't require resizing, because we know the nuniques at this point.

Metadata

Metadata

Assignees

No one assigned

    Labels

    CleanPerformanceMemory or execution speed performance

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions