TST: failing builds on master

[jreback]

• 3.4 slow https://travis-ci.org/pandas-dev/pandas/jobs/181534281

======================================================================
FAIL: test_bar_log_no_subplots (pandas.tests.plotting.test_frame.TestDataFramePlots)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/pandas-dev/pandas/pandas/tests/plotting/test_frame.py", line 1130, in test_bar_log_no_subplots
    tm.assert_numpy_array_equal(ax.yaxis.get_ticklocs(), expected)
  File "/home/travis/build/pandas-dev/pandas/pandas/util/testing.py", line 1079, in assert_numpy_array_equal
    _raise(left, right, err_msg)
  File "/home/travis/build/pandas-dev/pandas/pandas/util/testing.py", line 1062, in _raise
    .format(obj), left.shape, right.shape)
  File "/home/travis/build/pandas-dev/pandas/pandas/util/testing.py", line 1018, in raise_assert_detail
    raise AssertionError(msg)
AssertionError: numpy array are different
numpy array shapes are different
[left]:  (5,)
[right]: (4,)
======================================================================
FAIL: test_bar_log_subplots (pandas.tests.plotting.test_frame.TestDataFramePlots)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/pandas-dev/pandas/pandas/tests/plotting/test_frame.py", line 1141, in test_bar_log_subplots
    tm.assert_numpy_array_equal(ax[0].yaxis.get_ticklocs(), expected)
  File "/home/travis/build/pandas-dev/pandas/pandas/util/testing.py", line 1079, in assert_numpy_array_equal
    _raise(left, right, err_msg)
  File "/home/travis/build/pandas-dev/pandas/pandas/util/testing.py", line 1062, in _raise
    .format(obj), left.shape, right.shape)
  File "/home/travis/build/pandas-dev/pandas/pandas/util/testing.py", line 1018, in raise_assert_detail
    raise AssertionError(msg)
AssertionError: numpy array are different
numpy array shapes are different
[left]:  (7,)
[right]: (6,)
======================================================================
FAIL: test_bar_log (pandas.tests.plotting.test_series.TestSeriesPlots)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/pandas-dev/pandas/pandas/tests/plotting/test_series.py", line 207, in test_bar_log
    tm.assert_numpy_array_equal(ax.yaxis.get_ticklocs(), expected)
  File "/home/travis/build/pandas-dev/pandas/pandas/util/testing.py", line 1079, in assert_numpy_array_equal
    _raise(left, right, err_msg)
  File "/home/travis/build/pandas-dev/pandas/pandas/util/testing.py", line 1062, in _raise
    .format(obj), left.shape, right.shape)
  File "/home/travis/build/pandas-dev/pandas/pandas/util/testing.py", line 1018, in raise_assert_detail
    raise AssertionError(msg)
AssertionError: numpy array are different
numpy array shapes are different
[left]:  (7,)
[right]: (6,)
----------------------------------------------------------------------
Ran 252 tests in 1103.335s

• numpy-dev build: https://travis-ci.org/pandas-dev/pandas/jobs/181534284, closed by COMPAT: numpy compat with 1-ndim object array compat and broadcasting #14809

======================================================================
ERROR: test_scalar_na_cmp_corners (pandas.tests.series.test_operators.TestSeriesOperators)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/pandas-dev/pandas/pandas/core/ops.py", line 1170, in na_op
    raise_on_error=True, **eval_kwargs)
  File "/home/travis/build/pandas-dev/pandas/pandas/computation/expressions.py", line 210, in evaluate
    **eval_kwargs)
  File "/home/travis/build/pandas-dev/pandas/pandas/computation/expressions.py", line 63, in _evaluate_standard
    return op(a, b)
TypeError: unsupported operand type(s) for &: 'float' and 'float'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/home/travis/build/pandas-dev/pandas/pandas/core/internals.py", line 1160, in eval
    result = get_result(other)
  File "/home/travis/build/pandas-dev/pandas/pandas/core/internals.py", line 1129, in get_result
    result = func(values, other)
  File "/home/travis/build/pandas-dev/pandas/pandas/core/ops.py", line 1179, in na_op
    yrav = yrav[mask]
IndexError: boolean index did not match indexed array along dimension 0; dimension is 1 but corresponding boolean dimension is 9
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/home/travis/build/pandas-dev/pandas/pandas/tests/series/test_operators.py", line 1417, in test_scalar_na_cmp_corners
    self.assertRaises(ValueError, lambda: d.__and__(s, axis='columns'))
  File "/home/travis/build/pandas-dev/pandas/pandas/util/testing.py", line 2380, in assertRaises
    _callable(*args, **kwargs)
  File "/home/travis/build/pandas-dev/pandas/pandas/tests/series/test_operators.py", line 1417, in <lambda>
    self.assertRaises(ValueError, lambda: d.__and__(s, axis='columns'))
  File "/home/travis/build/pandas-dev/pandas/pandas/core/ops.py", line 1223, in f
    return self._combine_series(other, na_op, fill_value, axis, level)
  File "/home/travis/build/pandas-dev/pandas/pandas/core/frame.py", line 3539, in _combine_series
    fill_value=fill_value)
  File "/home/travis/build/pandas-dev/pandas/pandas/core/frame.py", line 3573, in _combine_match_columns
    axes=[left.columns, self.index])
  File "/home/travis/build/pandas-dev/pandas/pandas/core/internals.py", line 3163, in eval
    return self.apply('eval', **kwargs)
  File "/home/travis/build/pandas-dev/pandas/pandas/core/internals.py", line 3057, in apply
    applied = getattr(b, f)(**kwargs)
  File "/home/travis/build/pandas-dev/pandas/pandas/core/internals.py", line 1167, in eval
    result = handle_error()
  File "/home/travis/build/pandas-dev/pandas/pandas/core/internals.py", line 1150, in handle_error
    (repr(other), str(detail)))  # noqa
TypeError: Could not operate array([nan], dtype=object) with block values boolean index did not match indexed array along dimension 0; dimension is 1 but corresponding boolean dimension is 9
----------------------------------------------------------------------

[jorisvandenbossche]

The first ones (plotting failures) started due to PR #14747, although the PR looks unrelated (and only started failing on the master branch, not in the PR)

[jorisvandenbossche]

It's probably matplotlib 2.0.0b4 -> 2.0.0rc1 that is the culprit (that's a difference between the failing and passing builds)

[jorisvandenbossche]

@tacaswell

matplotlib 1.5.2:

In [2]: matplotlib.__version__
Out[2]: '1.5.2'

In [3]: df = pd.DataFrame({'A': [3] * 5, 'B': range(1, 6)}, index=range(5))

In [6]: ax = df.plot(kind='bar', grid=True, log=True)

In [7]: ax.yaxis.get_ticklocs()
Out[7]: array([   0.1,    1. ,   10. ,  100. ])

In [8]: [t.get_text() for t in ax.yaxis.get_ticklabels()]
Out[8]: ['', '$\\mathdefault{10^{0}}$', '$\\mathdefault{10^{1}}$', '']

matplotlib 2.0.0b4:

In [3]: matplotlib.__version__
Out[3]: '2.0.0b4'

In [4]: df = pd.DataFrame({'A': [3] * 5, 'B': range(1, 6)}, index=range(5))

In [5]: ax = df.plot(kind='bar', grid=True, log=True)

In [6]: ax.yaxis.get_ticklocs()
Out[6]: array([   0.1,    1. ,   10. ,  100. ])

In [7]: [t.get_text() for t in ax.yaxis.get_ticklabels()]
Out[7]: ['', '${10^{0}}$', '', '']

With matplotlib 2.0.0rc1

In [3]: matplotlib.__version__
Out[3]: '2.0.0rc1'

In [4]: df = pd.DataFrame({'A': [3] * 5, 'B': range(1, 6)}, index=range(5))

In [5]: ax = df.plot(kind='bar', grid=True, log=True)

In [6]: ax.yaxis.get_ticklocs()
Out[6]: 
array([  1.00000000e-02,   1.00000000e-01,   1.00000000e+00,
         1.00000000e+01,   1.00000000e+02])

In [7]: [t.get_text() for t in ax.yaxis.get_ticklabels()]
Out[7]: ['', '', '${10^{0}}$', '', '']

I suppose the change in the labels is intentional? ("vastly improved log scale ticks" in your rc1 announcement email. By the way, although you put this in your email as one of the highlights, it is almost not mentioned in the "What's new" / "Changes to the default style" documents)
But, is the fact that the ticklocs now are one element longer (and include two values for which there is no label at the start) also intentional? If so, we will just adjust our tests, that's no problem.

[jorisvandenbossche]

@tacaswell Can you give a quick confirmation that this change is intentional? (or not) Then I just adapt our tests.

[tacaswell]

Sorry it took me so long to respond, this got lost in the wall of gh notifications I get 😞. I got behind about a month ago and am slowly digging my self back out. In the future, if you need my attention for pandas related plotting issues and I am not responding on GH feel free to escalate communication channels.

The extra tick labels are intentional, the lack of write up in the what's new is because our doc-writing is behind our code writing.

The space at the bottom is not

[jorisvandenbossche]

@tacaswell No problem!
Just to check: the space at the bottom was a bug that is solved since rc1? The extra minor ticklabels are indeed intentional, but was the extra major tickloc at 0.01 (without label) a consequence of the erroneous space? Or was this intentional as well.

Sorry for the questions, I currently don't have a master version of matplotlib, only the tagged rc, installed.

[tacaswell]

In [1]: import pandas as pd

In [2]: import matplotlib.pyplot as plt
plt.i
In [3]: plt.ion()

In [4]: df = pd.DataFrame({'A': [3] * 5, 'B': range(1, 6)}, index=range(5))

In [5]: ax = df.plot(kind='bar', grid=True, log=True)

In [6]: ax.yaxis.get_ticklocs()
Out[6]: array([   0.1,    1. ,   10. ,  100. ])

In [7]: [t.get_text() for t in ax.yaxis.get_ticklabels()]
Out[7]: ['', '${10^{0}}$', '', '']

In [8]: plt.matplotlib.__version__
Out[8]: '2.0.0rc1.post77+gf99ae8b'

I think the not-visible ticks are something we consider a private detail (or maybe I just wish they were a private detail 😉 ).

attn @efiring

[tacaswell]

Assuming my internet comes back overnight, there should be an rc2 tomorrow.