Skip to content

TST/COMPAT: python 3.5 compat #11097

Closed
@jreback

Description

@jreback

A few changes are needed: https://travis-ci.org/jreback/pandas/jobs/80331174 (since merged to master)

so the Call node as changed
need to do something like this: https://bitbucket.org/pytest-dev/pytest/pull-requests/296/astcall-signature-changed-on-35/diff

If this is fixed I think everything will pass. I guess this is an API change in python.

======================================================================
ERROR: test_df_use_case (pandas.computation.tests.test_eval.TestMathNumExprPandas)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/jreback/pandas/pandas/computation/tests/test_eval.py", line 1488, in test_df_use_case
    parser=self.parser)
  File "/home/travis/build/jreback/pandas/pandas/core/frame.py", line 2102, in eval
    return _eval(expr, **kwargs)
  File "/home/travis/build/jreback/pandas/pandas/computation/eval.py", line 230, in eval
    truediv=truediv)
  File "/home/travis/build/jreback/pandas/pandas/computation/expr.py", line 656, in __init__
    self.terms = self.parse()
  File "/home/travis/build/jreback/pandas/pandas/computation/expr.py", line 673, in parse
    return self._visitor.visit(self.expr)
  File "/home/travis/build/jreback/pandas/pandas/computation/expr.py", line 314, in visit
    return visitor(node, **kwargs)
  File "/home/travis/build/jreback/pandas/pandas/computation/expr.py", line 320, in visit_Module
    return self.visit(expr, **kwargs)
  File "/home/travis/build/jreback/pandas/pandas/computation/expr.py", line 314, in visit
    return visitor(node, **kwargs)
  File "/home/travis/build/jreback/pandas/pandas/computation/expr.py", line 498, in visit_Assign
    return self.visit(node.value, **kwargs)
  File "/home/travis/build/jreback/pandas/pandas/computation/expr.py", line 314, in visit
    return visitor(node, **kwargs)
  File "/home/travis/build/jreback/pandas/pandas/computation/expr.py", line 543, in visit_Call
    args = [self.visit(targ) for targ in node.args]
  File "/home/travis/build/jreback/pandas/pandas/computation/expr.py", line 543, in <listcomp>
    args = [self.visit(targ) for targ in node.args]
  File "/home/travis/build/jreback/pandas/pandas/computation/expr.py", line 314, in visit
    return visitor(node, **kwargs)
  File "/home/travis/build/jreback/pandas/pandas/computation/expr.py", line 545, in visit_Call
    if node.starargs is not None:
AttributeError: 'Call' object has no attribute 'starargs'

Metadata

Metadata

Assignees

No one assigned

    Labels

    Compatpandas objects compatability with Numpy or Python functionsTestingpandas testing functions or related to the test suite

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions