Skip to content

Add type annotation to the return value of Index#get_loc #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

skatsuta
Copy link
Contributor

  • Tests added: Please use assert_type() to assert the type of any return value

Add type annotation to the return value of Index#get_loc.

@skatsuta skatsuta force-pushed the index-get-loc-return-type branch from fee34e8 to 18ba64a Compare February 11, 2024 15:18
@skatsuta skatsuta marked this pull request as ready for review February 11, 2024 15:48
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @skatsuta

@Dr-Irv Dr-Irv merged commit fe28163 into pandas-dev:main Feb 12, 2024
@skatsuta skatsuta deleted the index-get-loc-return-type branch February 13, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants