gh-548 #551
Merged
gh-548 #551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dr-Irv
requested changes
Feb 22, 2023
| self, axis: AxisType = ..., skipna: bool = ..., numeric_only: bool = ... | ||
| ) -> Series: ... | ||
| def idxmin( | ||
| self, axis: AxisType = ..., skipna: bool = ..., numeric_only: bool = ... |
There was a problem hiding this comment.
Looking at the code, it turns out that numeric_only is not a parameter for SeriesGroupBy.idxmax() and SeriesGroupBy.idxmin(), so can you remove them?
twoertwein
pushed a commit
to twoertwein/pandas-stubs
that referenced
this pull request
Apr 1, 2023
* chore: update function definition * chore: added idxmax and idxmin tests * chore: remove numeric_only from series
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return value