Skip to content

Allow str to be passing to rolling() window and use IntervalClosedType literal for series as well #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2022

Conversation

gandhis1
Copy link
Contributor

  • Tests added: Please use assert_type() to assert the type of any return value

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @gandhis1

As mentioned elsewhere, can you create an issue in the pandas repo that DataFrame.rolling() and Series.rolling() should show that a string is a valid argument?

@Dr-Irv Dr-Irv merged commit 5f86351 into pandas-dev:main Oct 14, 2022
bashtage pushed a commit to bashtage/pandas-stubs that referenced this pull request Oct 19, 2022
…e literal for series as well (pandas-dev#385)

* Allow str to be passed to rolling() window parameter and re-use IntervalClosedType literal for series as well

* Add VSCode project settings folder to .gitignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants