Skip to content

Change ExcelWriter modes to {"w","a"} #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 6, 2022
Merged

Change ExcelWriter modes to {"w","a"} #358

merged 3 commits into from
Oct 6, 2022

Conversation

cameronb-ma
Copy link
Contributor

@cameronb-ma cameronb-ma commented Oct 5, 2022 •
edited by bashtage
Loading

@bashtage
Copy link
Contributor

bashtage commented Oct 5, 2022

Could you try to write a test that uses mode a. Perhaps write a files, then close it, and then open mode a.

@cameronb-ma cameronb-ma changed the title Change ExcelWriter modes to {"w","a") Change ExcelWriter modes to {"w","a"} Oct 5, 2022
@bashtage
Copy link
Contributor

bashtage commented Oct 5, 2022

LGTM. Just waiting for a green.

@bashtage bashtage self-requested a review October 5, 2022 14:21
twoertwein
twoertwein reviewed Oct 5, 2022
View reviewed changes
@twoertwein twoertwein requested a review from Dr-Irv October 5, 2022 15:19
Dr-Irv
Dr-Irv approved these changes Oct 6, 2022
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @cameronb-ma

@Dr-Irv Dr-Irv merged commit b12acc1 into pandas-dev:main Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twoertwein twoertwein twoertwein left review comments

@Dr-Irv Dr-Irv Dr-Irv approved these changes

@bashtage bashtage Awaiting requested review from bashtage

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ExcelWriter mode error
4 participants
@cameronb-ma @bashtage @twoertwein @Dr-Irv