Skip to content

ENH: Add typing for to_numeric #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 11, 2022
Merged

ENH: Add typing for to_numeric #354

merged 5 commits into from
Oct 11, 2022

Conversation

bashtage
Copy link
Contributor

@bashtage bashtage commented Oct 4, 2022

  • Tests added: Please use assert_type() to assert the type of any return value

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also need to resolve conflicts

@bashtage bashtage requested a review from Dr-Irv October 11, 2022 16:07
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @bashtage

@Dr-Irv Dr-Irv merged commit 5cfc849 into pandas-dev:main Oct 11, 2022
@bashtage bashtage deleted the to-numeric branch November 8, 2022 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants