Skip to content

ENH: Imprpve interval_range and IntervalIndex #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 3, 2022

Conversation

bashtage
Copy link
Contributor

@bashtage bashtage commented Oct 1, 2022

  • Tests added: Please use assert_type() to assert the type of any return value

@bashtage bashtage changed the title ENH: IMrpve interval_range and IntervalIndex ENH: Imprpve interval_range and IntervalIndex Oct 2, 2022
@bashtage
Copy link
Contributor Author

bashtage commented Oct 2, 2022

Tests added, comments fixed, and green.

@bashtage bashtage requested a review from Dr-Irv October 2, 2022 23:13
@@ -25,6 +31,20 @@ from pandas._typing import (
from pandas.core.dtypes.dtypes import IntervalDtype as IntervalDtype
from pandas.core.dtypes.generic import ABCSeries

_Edges: TypeAlias = Union[
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice idea

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @bashtage

@Dr-Irv Dr-Irv merged commit 2311c49 into pandas-dev:main Oct 3, 2022
@bashtage bashtage deleted the interval_range branch October 5, 2022 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants