ENH: Allow TextClause #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandhis1
reviewed
Sep 20, 2022
pandas-stubs/io/sql.pyi
Outdated
| @@ -28,6 +28,10 @@ _SQLConnection = Union[ | |||
| sqlite3.Connection, | |||
| ] | |||
|
|
|||
| _SQLStatement = Union[ | |||
| str, sqlalchemy.sql.expression.Selectable, sqlalchemy.sql.elements.TextClause | |||
There was a problem hiding this comment.
need to import sqlalchemy.sql.elements
There was a problem hiding this comment.
On second thought, probably best to be consistent with Selectable and import it from sqlalchemy.sql.expression instead, rather than directly from the underlying module. sqlalchemy.sql.expression seems to be re-exporting a bunch of stuff from elements
There was a problem hiding this comment.
Thanks. I agree expression is the right endpoint, also based on https://docs.sqlalchemy.org/en/14/core/sqlelement.html#sqlalchemy.sql.expression.TextClause
Allow sqlalchemy TextClause for sql select statements
bashtage
force-pushed
the
text-clause-sql
branch
from
03a5bdb to
960d42e
Compare
Dr-Irv
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow sqlalchemy TextClause for sql select statements
assert_type()to assert the type of any return value