stubtest inconsistencies #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Sep 19, 2022
|
How are you running stubtest? |
Could maybe start creating a small allowlist to cover deprecated arguments? |
twoertwein
force-pushed
the
stubtest
branch
from
55a1a77 to
43fdc06
Compare
twoertwein
commented
Sep 20, 2022
Dr-Irv
requested changes
Sep 21, 2022
pandas-stubs/core/missing.pyi
Outdated
| @@ -1,7 +1,7 @@ | |||
| def mask_missing(arr, values_to_mask): ... | |||
| def clean_fill_method(method, allow_nearest: bool = ...): ... | |||
| def clean_interp_method(method, **kwargs): ... | |||
| def find_valid_index(values, how: str): ... | |||
| def find_valid_index(values, how: str = ...): ... | |||
There was a problem hiding this comment.
Not in the docs, so delete??
I started to have a small allowlist for stubtest: There is obviously much more to add. I did not add it, but I'm happy to add it if other people also use stubtest and/or want to extent this list. |
Dr-Irv
approved these changes
Sep 21, 2022
|
thanks @twoertwein |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was trying to go through the "differs from runtime argument" errors from stubtest. Stubtest reports too many (redundant/slightly misleading) errors python/mypy#13676 - I wasn't motivated enough to parse its long output.