-
-
Notifications
You must be signed in to change notification settings - Fork 143
Add py.typed #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add py.typed #260
Conversation
A much easier fix would be to simply have @Dr-Irv I now you removed it at some point because of a bug(?) in pyright. Is it now safe to enable it again? |
Don't know. If that would work, I'd prefer it over having to rename |
If I remove |
ABCSeries = type[Series] | ||
ABCDataFrame = type[DataFrame] | ||
|
||
ABCExtensionArray = type[ExtensionArray] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically need only ABCExtensionArray
and ABCSeries
for the current stubs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should have py.typed
with the word partial
in it.
https://peps.python.org/pep-0561/
If we add |
OK, I'm fine with that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @twoertwein
ABCExtensionArray
andABCSeries
did not exist in the stubs but this error might have been hidden because the pandas implementation provides it.