Skip to content

__neg__ methods and bugfix #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 2, 2022
Merged

__neg__ methods and bugfix #253

merged 3 commits into from
Sep 2, 2022

Conversation

amotzop
Copy link
Contributor

@amotzop amotzop commented Sep 2, 2022

Added __neg__ method to Series, DataFrame and Index.
Fixed a bug in Index.difference and added a relevant test.

@amotzop
Copy link
Contributor Author

amotzop commented Sep 2, 2022

There might be a better solution to the Index.difference problem, but nothing I tried seemed to satisfy both test cases other than getting rid of the T1 inside the list.

bashtage
bashtage requested changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@bashtage bashtage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check pos too

Dr-Irv
Dr-Irv requested changes Sep 2, 2022
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For each of the tests you added, can you add a comment at the beginning of each test function (or new test within an existing test function) pointing back to this PR. Something like # GH 253

Dr-Irv
Dr-Irv approved these changes Sep 2, 2022
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amotzop

@Dr-Irv Dr-Irv merged commit 426e31d into pandas-dev:main Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twoertwein twoertwein twoertwein left review comments

@bashtage bashtage bashtage requested changes

@Dr-Irv Dr-Irv Dr-Irv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amotzop @bashtage @twoertwein @Dr-Irv