-
-
Notifications
You must be signed in to change notification settings - Fork 144
ENH: Improve clipboard #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Synchronize clipboard with upstream pandas
Pretty hard to add tests for so nothing added so far. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that the kwargs
are the same as read_csv
for read_clipboard
and the same as to_csv
for to_clipboard
, we should copy those arguments over to here, and remove the kwargs
For testing, you could do a to_clipboard
followed by read_clipboard
Clipboard testing doesn't work on linux CI without extra setup. Maintaining the CI setup is not worth it IMO. I will skip the test if the to_clipboard fails. |
Test added. It runs on windows but not linux. |
@bashtage Do you think you could do this as well? No need to add a test for all the args, but you could copy them over. |
Expand kwargs Add types for all read_csv args
I've added the kwargs from read_csv - Warning: There are a lot. Turns out clipboard can also return a TextFileReader too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @bashtage
Synchronize clipboard with upstream pandas
assert_type()
to assert the type of any return value