More specific types for GroupBy.apply. #177
Conversation
danielroseman
force-pushed
the
fix-groupby-apply
branch
from
e331554 to
55d0bef
Compare
| @overload | ||
| def apply( # type: ignore[misc] | ||
| self, func: Callable[[DataFrame], Series | Scalar], *args, **kwargs | ||
| self, func: Callable[[Iterable], float], *args, **kwargs |
There was a problem hiding this comment.
The Callable[[Iterable]... should come last, because you want the other ones to match first. I think that will make pyright not see things as overlapping.
There was a problem hiding this comment.
I thought that originally. But then mypy gives the following error:
tests/test_frame.py:559: error: Incompatible types in assignment (expression has type "Series[Any]", variable has type "DataFrame") [assignment]
I can't really explain that behaviour, because according to everything I can find mypy should also match in order.
There was a problem hiding this comment.
I just tried moving it last and it worked. Still had pyright complain about the last overload never being matched without the #type: ignore in there, but it did work. Can you try again?
There was a problem hiding this comment.
Apologies, looks like I had the previous version of mypy. Running the reordered code against the latest version works correctly.
| @overload | ||
| def apply( # type: ignore[misc] | ||
| self, func: Callable[[DataFrame], Series | Scalar], *args, **kwargs | ||
| self, func: Callable[[Iterable], float], *args, **kwargs |
There was a problem hiding this comment.
I just tried moving it last and it worked. Still had pyright complain about the last overload never being matched without the #type: ignore in there, but it did work. Can you try again?
|
|
assert_type()to assert the type of any return valueThanks for the previous change (#168) on this issue, but unfortunately it didn't quite cover all the use cases - on my code base it frequently fell through to the union of DataFrame and Series, which would have required a lot of extra narrowing. This change is more specific and adds some extra test cases which should catch all the variants.
Also added a missing
summethod on SeriesGroupBy.