Skip to content

Fixed typing on IntervalIndex functions #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 31, 2022
Merged

Fixed typing on IntervalIndex functions #174

merged 2 commits into from
Jul 31, 2022

Conversation

amotzop
Copy link
Contributor

@amotzop amotzop commented Jul 30, 2022

  • Added typing to some of the methods of IntervalIndex.
  • Removed IntervalIndex methods that are inherited from Index.
  • Tests added: test_interval_index.py checking the function from_breaks, from_arrays, from_tuples and is_overlapping.

twoertwein
twoertwein reviewed Jul 30, 2022
View reviewed changes
Dr-Irv
Dr-Irv requested changes Jul 31, 2022
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from comment to use IntervalClosedType, need to fix style issues that cause CI to fail

Dr-Irv
Dr-Irv approved these changes Jul 31, 2022
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amotzop

@Dr-Irv Dr-Irv merged commit a8bc6c6 into pandas-dev:main Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twoertwein twoertwein twoertwein approved these changes

@Dr-Irv Dr-Irv Dr-Irv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amotzop @twoertwein @Dr-Irv