Skip to content

CLEAN: Align Groupby types #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2022
Merged

Conversation

Dr-Irv
Copy link
Collaborator

@Dr-Irv Dr-Irv commented Jul 23, 2022

pandas has BaseGroupBy (which should be private), whereas the stubs had _GroupBy, but I wanted to get things aligned. Probably BaseGroupBy should be private in pandas.

In addition, SelectionMixin is really an abstract class, so removing aggregate makes sense, as the pandas implementation raises an exception anyway.

@Dr-Irv Dr-Irv requested a review from twoertwein July 23, 2022 21:55
Copy link
Member

@twoertwein twoertwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition, SelectionMixin is really an abstract class, so removing aggregate makes sense, as the pandas implementation raises an exception anyway.

Could let it return NoReturn but that is not worth it.

@twoertwein twoertwein merged commit 927d438 into pandas-dev:main Jul 23, 2022
@twoertwein
Copy link
Member

Thank you @Dr-Irv

@Dr-Irv Dr-Irv deleted the aligngroupby branch December 28, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLEAN: Fix up Groupby classes
2 participants