Skip to content

GH1203 Pass a dict to setter for DataFrame.loc/iloc #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2025
Merged

GH1203 Pass a dict to setter for DataFrame.loc/iloc #1204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11a7bd9
gh1203_loc_dict
loicdiridollou Apr 27, 2025
9e810cc
GH1203 PR feedback
loicdiridollou Apr 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions pandas-stubs/core/frame.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,16 @@ class _iLocIndexerFrame(_iLocIndexer, Generic[_T]):
| tuple[IndexType, IndexType]
| tuple[int, IndexType]
),
value: Scalar | Series | DataFrame | np.ndarray | NAType | NaTType | None,
value: (
Scalar
| Series
| DataFrame
| np.ndarray
| NAType
| NaTType
| Mapping[Hashable, Scalar | NAType | NaTType]
| None
),
) -> None: ...

class _LocIndexerFrame(_LocIndexer, Generic[_T]):
Expand Down Expand Up @@ -239,13 +248,23 @@ class _LocIndexerFrame(_LocIndexer, Generic[_T]):
idx: (
MaskType | StrLike | _IndexSliceTuple | list[ScalarT] | IndexingInt | slice
),
value: Scalar | NAType | NaTType | ArrayLike | Series | DataFrame | list | None,
value: (
Scalar
| NAType
| NaTType
| ArrayLike
| Series
| DataFrame
| list
| Mapping[Hashable, Scalar | NAType | NaTType]
| None
),
) -> None: ...
@overload
def __setitem__(
self,
idx: tuple[_IndexSliceTuple, Hashable],
value: Scalar | NAType | NaTType | ArrayLike | Series | list | None,
value: Scalar | NAType | NaTType | ArrayLike | Series | list | dict | None,
) -> None: ...

# With mypy 1.14.1 and python 3.12, the second overload needs a type-ignore statement
Expand Down
10 changes: 10 additions & 0 deletions tests/test_frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4134,3 +4134,13 @@ def test_combine() -> None:
),
pd.DataFrame,
)


def test_df_loc_dict() -> None:
"""Test that we can set a dict to a df.loc result GH1203."""
df = pd.DataFrame(columns=["X"])
df.loc[0] = {"X": 0}
check(assert_type(df, pd.DataFrame), pd.DataFrame)

df.iloc[0] = {"X": 0}
check(assert_type(df, pd.DataFrame), pd.DataFrame)