GH571 Update typehint when creating a Series from an empty list #1029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dr-Irv
requested changes
Nov 11, 2024
tests/test_frame.py
Outdated
|
|
||
| def test_series_empty_dtype() -> None: | ||
| """Test for the creation of a Series from an empty list GH571.""" | ||
| new_tab: Sequence[Never] = [] |
There was a problem hiding this comment.
For the test, it should work without setting a type for new_tab. So if you change this line to new_tab = [], does the empty list match Sequence[Never] ?
also, double check that passing an empty string will NOT match this, because strings are sequences, and I'm not sure if "" would be an OK match for Sequence[Never]
There was a problem hiding this comment.
Thanks for the feedback, in order:
mypyraises an error when instantiating an empty sequence so I needed to annotate it
===========================================
Beginning: 'Run mypy on 'tests' (using the local stubs) and on the local stubs'
===========================================
tests/test_frame.py:3566: error: Need type annotation for "new_tab" (hint: "new_tab: list[<type>] = ...") [var-annotated]
Found 1 error in 1 file (checked 226 source files)
- I have added a test for the empty string
There was a problem hiding this comment.
FYI this is the error that you get when trying to typehint "" as a Sequence[Never] so the types are well separated.
tests/test_frame.py:3571: error: Incompatible types in assignment (expression has type "str", variable has type "Sequence[Never]") [assignment]
for mypy above and pyright below
Diagnostics:
Type "Literal['']" is not assignable to declared type "Sequence[Never]"
"Literal['']" is not assignable to "Sequence[Never]"
Type parameter "_T_co@Sequence" is covariant, but "str" is not a subtype of "Never"
Type "str" is not assignable to type "Never" [reportAssignmentType]
There was a problem hiding this comment.
OK, I see that you added an explicit test for pd.Series([]), so the issue with new_tab is nothing to worry about.
2 tasks
pan-vlados
added a commit
to pan-vlados/pandas-stubs
that referenced
this pull request
Dec 18, 2024
- fix Index.str.split method return wrong result;
- add test for Index.str.split method with expand=False;
- return changes performed in pull request pandas-dev#1029.
Dr-Irv
added a commit
that referenced
this pull request
Dec 18, 2024
…nd=False (#1075) * GH1074 Add type hint Series[list[str]] for Series.str.split with expand=False * Updates: - fix Index.str.split method return wrong result; - add test for Index.str.split method with expand=False; - return changes performed in pull request #1029. * Update tests/test_indexes.py Co-authored-by: Irv Lustig <irv@princeton.com> * Update tests/test_series.py Co-authored-by: Irv Lustig <irv@princeton.com> * Update tests/test_series.py Co-authored-by: Irv Lustig <irv@princeton.com> * Updates: - combine two str.split overloads and keep only _TS and _TS2; - fix test_indexes.py test for test_str_split(). * pre-commit fixes * Add type hints and tests for str.rsplit() for expand=False --------- Co-authored-by: Irv Lustig <irv@princeton.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TimestampSeries#571assert_type()to assert the type of any return valuePotential fix for #571 to typehint a
Seriescreated from an empty list to be typed aspd.Series[Any].Open for feedback if this is not the optimal type.