Skip to content

Commit 6a2e123

Browse files
committed
Comment out the tests which produce conflicting results in Mypy and Pyright
Keep the tests as comments in order to document the behavior for future reference
1 parent 7ffcf82 commit 6a2e123

File tree

1 file changed

+20
-24
lines changed

1 file changed

+20
-24
lines changed

tests/test_pandas.py

Lines changed: 20 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -268,53 +268,49 @@ def test_isna() -> None:
268268
if pd.notna(nullable1):
269269
check(assert_type(nullable1, str), str)
270270
if not pd.isna(nullable1):
271-
# TODO: This is the true type (see comments above on the limitations of TypeGuard)
272-
# check(assert_type(nullable1, str), str)
271+
# check(assert_type(nullable1, str), str) # TODO: Desired result (see comments above)
273272
check(assert_type(nullable1, Union[str, NaTType, NAType, None]), str)
274273
if pd.isna(nullable1):
275274
assert_type(nullable1, Union[NaTType, NAType, None])
276275
if not pd.notna(nullable1):
277-
# TODO: This is the true type (see comments above on the limitations of TypeGuard)
278-
# assert_type(nullable1, Union[NaTType, NAType, None])
276+
# assert_type(nullable1, Union[NaTType, NAType, None]) # TODO: Desired result (see comments above)
279277
assert_type(nullable1, Union[str, NaTType, NAType, None])
280278

281279
nullable2 = random.choice([2, None])
282280
if pd.notna(nullable2):
283281
check(assert_type(nullable2, int), int)
284282
if not pd.isna(nullable2):
285-
# TODO: This is the true type (see comments above on the limitations of TypeGuard)
286-
# check(assert_type(nullable2, int), int)
283+
# check(assert_type(nullable2, int), int) # TODO: Desired result (see comments above)
287284
check(assert_type(nullable2, Union[int, None]), int)
288285
if pd.isna(nullable2):
289-
# TODO: This is the true type (see comments above on the limitations of TypeGuard)
290-
# check(assert_type(nullable2, None), type(None))
286+
# check(assert_type(nullable2, None), type(None)) # TODO: Desired result (see comments above)
291287
check(assert_type(nullable2, Union[NaTType, NAType, None]), type(None))
292288
if not pd.notna(nullable2):
293-
# TODO: This is the true type (see comments above on the limitations of TypeGuard)
294-
# check(assert_type(nullable2, None), type(None))
295-
assert_type(nullable2, Union[int, None]) # TODO: MyPy result
296-
assert_type(
297-
nullable2, Union[int, NaTType, NAType, None]
298-
) # TODO: Pyright result
289+
# check(assert_type(nullable2, None), type(None)) # TODO: Desired result (see comments above)
290+
# TODO: MyPy and Pyright produce conflicting results:
291+
# assert_type(nullable2, Union[int, None]) # MyPy result
292+
# assert_type(
293+
# nullable2, Union[int, NaTType, NAType, None]
294+
# ) # Pyright result
295+
pass
299296

300297
nullable3 = random.choice([True, None, pd.NA])
301298
if pd.notna(nullable3):
302299
check(assert_type(nullable3, bool), bool)
303300
if not pd.isna(nullable3):
304-
# TODO: This is the true type (see comments above on the limitations of TypeGuard)
305-
# check(assert_type(nullable3, bool), bool)
301+
# check(assert_type(nullable3, bool), bool) # TODO: Desired result (see comments above)
306302
check(assert_type(nullable3, Union[bool, NAType, None]), bool)
307303
if pd.isna(nullable3):
308-
# TODO: This is the true type (see comments above on the limitations of TypeGuard)
309-
# assert_type(nullable3, Union[NAType, None])
304+
# assert_type(nullable3, Union[NAType, None]) # TODO: Desired result (see comments above)
310305
assert_type(nullable3, Union[NaTType, NAType, None])
311306
if not pd.notna(nullable3):
312-
# TODO: This is the true type (see comments above on the limitations of TypeGuard)
313-
# assert_type(nullable3, Union[NAType, None])
314-
assert_type(nullable3, Union[bool, NAType, None]) # TODO: Mypy result
315-
assert_type(
316-
nullable3, Union[bool, NaTType, NAType, None]
317-
) # TODO: Pyright result
307+
# assert_type(nullable3, Union[NAType, None]) # TODO: Desired result (see comments above)
308+
# TODO: MyPy and Pyright produce conflicting results:
309+
# assert_type(nullable3, Union[bool, NAType, None]) # Mypy result
310+
# assert_type(
311+
# nullable3, Union[bool, NaTType, NAType, None]
312+
# ) # Pyright result
313+
pass
318314

319315

320316
# GH 55

0 commit comments

Comments
 (0)