Skip to content

Commit 7ffcf82

Browse files
committed
Document conflicting MyPy and pyright results
1 parent 534f518 commit 7ffcf82

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

tests/test_pandas.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,10 @@ def test_isna() -> None:
292292
if not pd.notna(nullable2):
293293
# TODO: This is the true type (see comments above on the limitations of TypeGuard)
294294
# check(assert_type(nullable2, None), type(None))
295-
assert_type(nullable2, Union[int, NaTType, NAType, None])
295+
assert_type(nullable2, Union[int, None]) # TODO: MyPy result
296+
assert_type(
297+
nullable2, Union[int, NaTType, NAType, None]
298+
) # TODO: Pyright result
296299

297300
nullable3 = random.choice([True, None, pd.NA])
298301
if pd.notna(nullable3):
@@ -308,7 +311,10 @@ def test_isna() -> None:
308311
if not pd.notna(nullable3):
309312
# TODO: This is the true type (see comments above on the limitations of TypeGuard)
310313
# assert_type(nullable3, Union[NAType, None])
311-
assert_type(nullable3, Union[bool, NaTType, NAType, None])
314+
assert_type(nullable3, Union[bool, NAType, None]) # TODO: Mypy result
315+
assert_type(
316+
nullable3, Union[bool, NaTType, NAType, None]
317+
) # TODO: Pyright result
312318

313319

314320
# GH 55

0 commit comments

Comments
 (0)