Skip to content

msc_regexec() != PCRE_ERROR_NOMATCH #3194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2024
Merged

msc_regexec() != PCRE_ERROR_NOMATCH #3194

merged 1 commit into from
Aug 12, 2024

Conversation

marcstern
Copy link

Return of msc_regexec() compared with PCRE_ERROR_NOMATCH (!=) to check if match.
Other errors may happen that would return -2, -3, ...
Matching would be incorrectly set in this case.
We must check if >= 0

…k if match.

Other errors may happen that would return -2, -3, ...
Matching would be incorrectly set in this case.
We must check if >= 0
@marcstern marcstern requested a review from airween July 22, 2024 15:09
@marcstern marcstern added the 2.x Related to ModSecurity version 2.x label Jul 22, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
14 Security Hotspots
91.4% Duplication on New Code (required ≤ 3%)
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@airween airween merged commit 914c1a1 into owasp-modsecurity:v2/master Aug 12, 2024
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to ModSecurity version 2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants