-
Notifications
You must be signed in to change notification settings - Fork 1.7k
CI improvement: First check syntax & always display error/audit logs #3190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Replaces #3172 |
Thanks @theseion for the review - @marcstern I think the suggestions (for using |
@theseion - thanks for your help again. Could you take a review again and resolve conversation where it's possible? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small changes. @marcstern please resolve the comments. Unfortunately, as owner of the review I can't resolve them myself.
Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It looks like my review doesn't count towards the merge check. Not sure why. |
@airween I found this: https://github.com/orgs/community/discussions/67622. Did you assign a specific role to me? |
First check syntax, in case no error.log is generated. this displays error on console.
Always show error.log (in sub-menu) after start. Even if error and CI processing stops. Same for audit log (even if empty for the moment)