Skip to content

CI improvement: First check syntax & always display error/audit logs #3190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 20, 2024
Merged

CI improvement: First check syntax & always display error/audit logs #3190

merged 10 commits into from
Aug 20, 2024

Conversation

marcstern
Copy link

First check syntax, in case no error.log is generated. this displays error on console.
Always show error.log (in sub-menu) after start. Even if error and CI processing stops. Same for audit log (even if empty for the moment)

@marcstern marcstern added the 2.x Related to ModSecurity version 2.x label Jul 22, 2024
@marcstern
Copy link
Author

Replaces #3172

@airween
Copy link
Member

airween commented Jul 27, 2024

Thanks @theseion for the review - @marcstern I think the suggestions (for using grep command) are useful. I'm not sure anyone will check Github logs after a CI run, so if the workflow shows there is any error in the log, that might be much helpfully.

@airween airween requested a review from theseion August 2, 2024 14:30
@airween
Copy link
Member

airween commented Aug 2, 2024

@theseion - thanks for your help again.

Could you take a review again and resolve conversation where it's possible?

Copy link
Collaborator

@theseion theseion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small changes. @marcstern please resolve the comments. Unfortunately, as owner of the review I can't resolve them myself.

airween and others added 2 commits August 19, 2024 16:47
Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com>
Copy link

Copy link
Member

@airween airween left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theseion
Copy link
Collaborator

It looks like my review doesn't count towards the merge check. Not sure why.

@theseion
Copy link
Collaborator

@airween I found this: https://github.com/orgs/community/discussions/67622. Did you assign a specific role to me?

@airween airween merged commit fd0e042 into owasp-modsecurity:v2/master Aug 20, 2024
41 checks passed
airween added a commit to airween/ModSecurity that referenced this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to ModSecurity version 2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants