Simplify checkout of submodules in GitHub workflows (with support for git describe) #3185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Checkout submodules in the GitHub QA workflows with the
checkout
action, but using thefetch-depth: 0
parameter to 'fetch all history for all tags and branches' for thegit describe
command to be able to identify the tag associated with each submodule's commit (if any).why
Previously, the GitHub workflows were using the
submodules: true
option, but this would not include tag information about each module sogit describe
would not show tag information in theconfigure
step of each build.As a workaround, in PR #3161 the
submodules
option was replaced with an additional step to explicitly callgit submodules init
&git submodules update
to address this (see changes to.github/workflows/ci.yml
in commit 7732b5e).As suggested by fzipi@ here, this could be addressed with the
fetch-depth: 0
option of thecheckout
action (see here), simplifying the workflow again.misc
Piggybacked simple typo in
Dockerfile
to build Windows version of the library introduced in commit 9e44964. 🤦