Skip to content

chore: add pull request template #3159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2024
Merged

chore: add pull request template #3159

merged 1 commit into from
May 30, 2024

Conversation

fzipi
Copy link
Contributor

@fzipi fzipi commented May 30, 2024

what

  • add PR template to help understand your change and help reviewers also

why

  • simplify review process
  • declare intention besides the title, as the implementation might differ or add more changes

@fzipi
chore: add PR template
bf6bf64 
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

airween
airween approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@airween airween left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@airween airween merged commit e7a6420 into owasp-modsecurity:v2/master May 30, 2024
41 checks passed
@fzipi fzipi mentioned this pull request May 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airween airween airween approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fzipi @airween