Skip to content

Missing null byte + optimization #3153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 28, 2024
Merged

Missing null byte + optimization #3153

merged 6 commits into from
May 28, 2024

Conversation

marcstern
Copy link

Replace a memset to 0 by a single assignment and fixing the 0 byte missing at the end when MSC_LARGE_STREAM_INPUT is not defined

@marcstern marcstern added the 2.x Related to ModSecurity version 2.x label May 28, 2024
@marcstern marcstern requested a review from airween May 28, 2024 13:43
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@airween airween left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@airween airween merged commit 8a3b620 into owasp-modsecurity:v2/master May 28, 2024
41 checks passed
@marcstern marcstern deleted the v2/LARGE_STREAM_INPUT_nullend branch May 29, 2024 10:57
@marcstern marcstern restored the v2/LARGE_STREAM_INPUT_nullend branch June 7, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to ModSecurity version 2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants