Add Regex::searchAllMatches method, remove searchAll #2394
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
searchAll interface was pretty strange, as it returned a reversed flattened list of all groups of all matches. For example, given the regexp "([a-z])([0-9])", and the string "a1b2", it would return the list ["2", "b", "b2", "1", "a", "a1"]. searchAllMatches introduces better interface. In the aforementioned scenario it would return [["a1", "a", "1"], ["b2", "b", "2"]]. Also, unlike searchAll, it doesn't make string copies itself, and returns just offsets, like searchOneMatch does.
|
Thanks @WGH-. @martinhsv : ping. That is somewhat in the same piece of code that you have worked with. |
|
I haven't reviewed this in detail, but it looks like it at least has the same correctness problem that I outlined in #2393 (that it always immediately advances the offset after finding an empty string as a full match). Note my other remarks in that pull request as well. To avoid too much implementation of overlapping functionality, it might be simplest to allow the rxGlobal + searchGlobal to proceed (assuming it passes muster), and then somewhat later look to migrate remaining users of searchAll to use searchGlobal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
searchAllinterface was pretty strange, as it returned a reversed flattened list of all groups of all matches. For example, given the regexp"([a-z])([0-9])", and the string"a1b2", it would return the list["2", "b", "b2", "1", "a", "a1"].searchAllMatchesintroduces better interface. In the aforementioned scenario it would return[["a1", "a", "1"], ["b2", "b", "2"]]. Also, unlikesearchAll, it doesn't make string copies itself, and returns just offsets, likesearchOneMatchdoes.