Implement support for Lua 5.1 #1814
Conversation
|
|
||
| lua_pop(L, nup); /* remove upvalues */ | ||
| } | ||
| #endif |
There was a problem hiding this comment.
Maybe the intent is to eventually promote support for LuaJIT with this PR (totally speculating here), but if so, and if I recall correctly, some versions of LuaJIT define LUA_VERSION_NUM as 501 and implement luaL_setfuncs. Should we follow Mike's advice here? See:
There was a problem hiding this comment.
If this isn't a goal nor a long-term goal of this PR, then feel free to ignore this!
There was a problem hiding this comment.
Hey @thibaultcha, the goal here is just to get support for 5.1 introduced. Trying to integrate with OpenResty was a bit of an exercise (see #1809), and there's no clean way to do it at this point (it was also the initial impetus for this PR). Eventually LuaJIT support might be nice, but since a number of distros only provide Lua lib packages for 5.1 out of the box, getting 5.1 supported is the sole goal here. As such I'd rather not introduce new symbols unnecessarily and increase the scope of this change.
If there's a large push for LuaJIT support here, perhaps we can revisit in the future, but at this point I do not see much value for that.
There was a problem hiding this comment.
There's an attempt to support LuaJIT on some distros at #1854. You might want to give it a try to see if it works for you @thibaultcha.
|
@victorhora @zimmerle any movement here? |
No description provided.