wktui-345 Correct display message when domain status is available. #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakillen
reviewed
Apr 4, 2022
electron/app/locales/en/webui.json
Outdated
| @@ -1186,7 +1186,7 @@ | |||
| "k8s-domain-status-checker-domain-status-unknown": "Unknown - Cannot determine the domain status now - check back later", | |||
| "k8s-domain-status-checker-domain-status-complete": "Complete - Domain is deployed and all servers are up and running", | |||
| "k8s-domain-status-checker-domain-status-failed": "Failed - Domain failed to deploy. Reason: {{reason}}", | |||
| "k8s-domain-status-checker-domain-status-available": "Available - Domain is deployed and some servers are up and running but the domain has not reaching the replicas count goal yet. Reason: {{reason}}", | |||
| "k8s-domain-status-checker-domain-status-available": "Available - Domain is deployed and some servers are up and running but the domain has not reaching the replicas count goal yet, check again later.", | |||
There was a problem hiding this comment.
"has not reaching" -> "has not reached"
robertpatrick
requested changes
Apr 5, 2022
electron/app/locales/en/webui.json
Outdated
| @@ -1186,7 +1186,7 @@ | |||
| "k8s-domain-status-checker-domain-status-unknown": "Unknown - Cannot determine the domain status now - check back later", | |||
| "k8s-domain-status-checker-domain-status-complete": "Complete - Domain is deployed and all servers are up and running", | |||
| "k8s-domain-status-checker-domain-status-failed": "Failed - Domain failed to deploy. Reason: {{reason}}", | |||
| "k8s-domain-status-checker-domain-status-available": "Available - Domain is deployed and some servers are up and running but the domain has not reaching the replicas count goal yet. Reason: {{reason}}", | |||
| "k8s-domain-status-checker-domain-status-available": "Available - Domain is deployed and some servers are up and running but the domain has not reached the replicas count goal yet, check again later.", | |||
There was a problem hiding this comment.
Hmm... In most cases, the reason is available and presumably helps the user quickly and easily understand the state. I don't feel like the solution to handling the transient situations where the reason is empty is to completely eliminate showing the reasons in all situations.
There was a problem hiding this comment.
changed the code to put out condition reasons
robertpatrick
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct message text when domain status is available, copy and paste error from other status type, there is no extra information in this status.