Increasing the robustness of the Remote Console backend port handling #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes several changes to the way the backend port is communicated to the BrowserWindows:
set-wrc-backend-portevent to all open BrowserWindows.window-is-ready.set-wrc-backend-portevent to all open BrowserWindows to set the window's backend port to undefined.In addition, this PR also short-circuits the deactivate/create process for the wdt-model-designer's data provider when the model changes due to receiving the changesAutoDownloaded callback. This should make it so that the only time the deactivate/create cycle is performed when the model changes due to an action cause by a menu invocation (or the Prepare Model button).