Developer guide missing build operator docker image #795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjeberhard
reviewed
Jan 15, 2019
site/developer.md
Outdated
| Log in to the Docker Store so that you will be able to pull the base image and create the Docker image as follows. These commands should be executed in the project root directory: | ||
|
|
||
| ``` | ||
| docker login |
There was a problem hiding this comment.
We've standardized on $ at the head of lines with shell commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The developer guide developer.md contains instructions on how to build the operator code, and on using the operator docker image, but there is no instruction on how to create the operator docker image after building the operator code.
This PR adds a "Building the operator Docker image" section to the developer.md, with contents from the installation.md from the 1.1 branch.
It also adds the "--build-arg VERSION=..." argument to the docker build command example, as suggested by issue #692